Skip to content

chore: address JavaScript lint error#12221

Closed
Aj242005 wants to merge 3 commits into
stdlib-js:developfrom
Aj242005:fix/issue-12208
Closed

chore: address JavaScript lint error#12221
Aj242005 wants to merge 3 commits into
stdlib-js:developfrom
Aj242005:fix/issue-12208

Conversation

@Aj242005
Copy link
Copy Markdown
Contributor

@Aj242005 Aj242005 commented May 20, 2026 •
edited
Loading

Resolves #12208

Description

What is the purpose of this pull request?
This pull request:

  • The Javascript lint workflow was flagging an error at 2 places
  • 1st one at lib/node_modules/@stdlib/plot/components/svg/defs/lib/main.js at 79th line , were previously there was a preallocated size array using
    args = new Array ( arguments.length + 1 ); args[0] = 'render' ; for ( i = 0; i<arguments.length;i++ ){ args[i+1] = arguments[i] } -> the lint workflow was flagging it because of presize allocation of array, i changed it to
    args = [ 'render' ]; for( i = 0; i<arguments.length; i++ ){ args.push( arguments[ i ] ); }
  • 2nd one at lib/node_modules/@stdlib/blas/base/ssyr/test/test.ndarray.js where there was an unexpected blank line at line 43, so the lint workflow was flagging it too --> removed it.

Related Issues

Does this pull request have any related issues?
This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?
No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

Aj242005 added 2 commits May 21, 2026 00:47
@Aj242005
Removed a blank line (previously at 43) which was causing a lint work…
8f3cf5f 
…flow issue

Removed a blank line (previously at line 43) which was causing a lint workflow issue

Signed-off-by: Akshit Jain <akshitjain6661@gmail.com>
@Aj242005
Refactor onRender function to handle linting issue ( previously on li…
e8d6eb5 
…ne 79th )

Signed-off-by: Akshit Jain <akshitjain6661@gmail.com>
@Aj242005 Aj242005 requested a review from a team May 20, 2026 19:46
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 20, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 20, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/base/ssyr $\color{green}616/616$
$\color{green}+0.00%$ 		$\color{green}82/82$
$\color{green}+0.00%$ 		$\color{green}5/5$
$\color{green}+0.00%$ 		$\color{green}616/616$
$\color{green}+0.00%$
plot/components/svg/defs $\color{green}215/215$
$\color{green}+0.00%$ 		$\color{green}9/9$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}215/215$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Aj242005 Aj242005 changed the title Fix/issue 12208 chore: address JavaScript lint error #12208 May 20, 2026
@Aj242005 Aj242005 changed the title chore: address JavaScript lint error #12208 chore: address JavaScript lint error May 20, 2026
@stdlib-bot stdlib-bot added the Merge Conflicts Pull request which has merge conflicts. label May 25, 2026
@kgryte kgryte added autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. and removed Needs Review A pull request which needs code review. labels May 27, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 27, 2026

Thank you for working on this pull request. However, we cannot accept your contribution due to Git history issues.

Some common issues include:

  • Merge conflicts
  • Inappropriate commit messages
  • Unrelated commits
  • Including changes from merged branches that weren't intended for this PR

We recommend opening a new pull request with only the intended changes.

Thank you for your interest in stdlib, and we look forward to your future contributions.

@stdlib-bot stdlib-bot closed this May 27, 2026
@Aj242005 Aj242005 deleted the fix/issue-12208 branch May 27, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. Good First PR A pull request resolving a Good First Issue. Merge Conflicts Pull request which has merge conflicts.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@Aj242005 @stdlib-bot @kgryte